Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added gyro_bias_estimator.param.yaml #69

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: added gyro_bias_estimator.param.yaml #69

wants to merge 1 commit into from

Conversation

TaikiYamada4
Copy link

Allow the system to edit the gyro_bias_estimator.param.yaml for each vehicle.

Added to the subdirectories that satisfies individual_params/config/*/aip_x*/

See the PR of aip_launcher for further explanation.

@TaikiYamada4
added gyro_bias_estimator.param.yaml to all configurations
16cdc1b 
Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>
@TaikiYamada4 TaikiYamada4 marked this pull request as ready for review March 13, 2024 07:57
shmpwk
shmpwk approved these changes Mar 28, 2024
View reviewed changes
Copy link

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TaikiYamada4 TaikiYamada4 marked this pull request as draft April 8, 2024 05:17
@0x126 0x126 removed their request for review September 20, 2024 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shmpwk shmpwk shmpwk approved these changes

@saka1-s saka1-s Awaiting requested review from saka1-s

@1222-takeshi 1222-takeshi Awaiting requested review from 1222-takeshi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TaikiYamada4 @shmpwk